Skip to content

Add snowshare #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Nov 3, 2025
Merged

Add snowshare #1063

merged 23 commits into from
Nov 3, 2025

Conversation

@TuroYT
Copy link
Contributor

@TuroYT TuroYT commented Oct 30, 2025

Scripts wich are clearly AI generated and not further revied by the Author of this PR (in terms of Coding Standards and Script Layout) may be closed without review.

✍️ Description

🔗 Related PR / Issue

Link: #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No breaking changes – Existing functionality remains intact.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

  • Follows Code_Audit.md & CONTRIBUTING.md guidelines
  • Uses correct script structure (AppName.sh, AppName-install.sh, AppName.json)
  • No hardcoded credentials

📋 Additional Information (optional)

@TuroYT TuroYT requested review from a team as code owners October 30, 2025 14:57
michelroegl-brunner
michelroegl-brunner requested changes Oct 30, 2025
View reviewed changes
Copy link
Member

@michelroegl-brunner michelroegl-brunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beofre i review that further:
You missed some coding standards we keep around here, but overall it dose not look to bad. First look in the latest merged Scripts for exampled. Second: We habe helper functions in tools.func to set up Node.js and Postgress.
3. We dont do git pulls, just downloads of releases. Ther also exists a helper function in tools.func.

Also please remove any comments, also you can then remove the jq check in the update part.
You can ping me when you did the changes, then i will have a deeper look into this pr.

TuroYT and others added 2 commits October 31, 2025 09:37
@TuroYT @michelroegl-brunner
Update ct/snowshare.sh
28b6a60 
Co-authored-by: Michel Roegl-Brunner <[email protected]>
@TuroYT @michelroegl-brunner
Update ct/snowshare.sh
77a82c7 
Co-authored-by: Michel Roegl-Brunner <[email protected]>
CrazyWolf13
CrazyWolf13 requested changes Oct 31, 2025
View reviewed changes
install/snowshare-install.sh Outdated
msg_ok "Installed SnowShare dependencies"

msg_info "Creating Environment Configuration"
cat <<EOF >/opt/snowshare/.env
Copy link
Member

@CrazyWolf13 CrazyWolf13 Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to /opt/snowshare.env if possible

Copy link
Member

@CrazyWolf13 CrazyWolf13 Nov 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this still applies (move to /opt/snowshare.env)

CrazyWolf13
CrazyWolf13 requested changes Oct 31, 2025
View reviewed changes
Copy link
Member

@CrazyWolf13 CrazyWolf13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks already pretty good, just some smaller things

MickLesk
MickLesk requested changes Oct 31, 2025
View reviewed changes
MickLesk
MickLesk requested changes Oct 31, 2025
View reviewed changes
@TuroYT
Copy link
Contributor Author

TuroYT commented Oct 31, 2025

i think its ok

CrazyWolf13
CrazyWolf13 requested changes Oct 31, 2025
View reviewed changes
@TuroYT TuroYT requested a review from CrazyWolf13 November 3, 2025 12:02
CrazyWolf13
CrazyWolf13 requested changes Nov 3, 2025
View reviewed changes
Copy link
Member

@CrazyWolf13 CrazyWolf13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some cosmetic things then good to me

install/snowshare-install.sh Outdated
msg_ok "Installed SnowShare dependencies"

msg_info "Creating Environment Configuration"
cat <<EOF >/opt/snowshare/.env
Copy link
Member

@CrazyWolf13 CrazyWolf13 Nov 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this still applies (move to /opt/snowshare.env)

@TuroYT TuroYT requested a review from CrazyWolf13 November 3, 2025 14:57
CrazyWolf13
CrazyWolf13 approved these changes Nov 3, 2025
View reviewed changes
Copy link
Member

@CrazyWolf13 CrazyWolf13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TuroYT I fixed the env location for you.

Please check if build works

@CrazyWolf13 CrazyWolf13 requested review from MickLesk and michelroegl-brunner and removed request for MickLesk and michelroegl-brunner November 3, 2025 15:24
@michelroegl-brunner michelroegl-brunner merged commit 5db13eb into community-scripts:main Nov 3, 2025
1 check passed
@TuroYT
Copy link
Contributor Author

TuroYT commented Nov 3, 2025

@CrazyWolf13 the build dont work with the snowshare.env

when npx prisma migrate deploy :

error: Environment variable not found: DATABASE_URL.
  -->  prisma/schema.prisma:14
   | 
13 |   provider = "postgresql"
14 |   url      = env("DATABASE_URL")
   | 

Validation Error Count: 1
[Context: getConfig]

@TuroYT TuroYT mentioned this pull request Nov 3, 2025
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michelroegl-brunner michelroegl-brunner michelroegl-brunner approved these changes

@CrazyWolf13 CrazyWolf13 CrazyWolf13 approved these changes

@MickLesk MickLesk Awaiting requested review from MickLesk

Assignees

No one assigned

Labels

core high risk maintenance new script website

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TuroYT @MickLesk @michelroegl-brunner @CrazyWolf13